Simple fix. You have an if check in your findurl subroutine. Don't set a global variable $url, but return it. Something like this:
sub findurl { my $url; open (INFO, $datafile) or die "Can't open $datafile: $!"; while (<INFO>) { my ($title, $location) = split(/\|/ , $_); if ($title eq $name) { $url = $location; } } close (INFO); return $url; }
That means you'll have to call it slightly differently:
my $url = findurl(); if (defined $url) { doit(); } else { incomplete(); }
I'd try to get rid of the global variables as far as possible, passing $name as an argument to findurl(), and $url as an argument to doit().

As for general coding advice, you ought to look into using the -w flag and strict. In CGI scripts, you should also use -T for taint checking (see perlsec), and there's usually no good reason not to use CGI instead of your parse subroutine. Yours doesn't handle checkboxes, for example.

Don't worry, these things will help you in the long run.


In reply to Re: Error 404 fix by chromatic
in thread Error 404 fix by koacamper

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.