comment on

A couple of comments:

OO modules generally don't use Exporter, as the methods are attached to objects, rather than being used as general subroutines:

package HTML::pageParser;

use warnings;  # could take this out in production code
use strict;
use Carp;
use vars qw($VERSION);
[download]

Unless you want to explicitly make new a copy constructor as well, just say

    my $proto = shift;
    my $class = $proto;
    my $sysLoc = shift;
    my $self  = {};
    $self->{tokens} = [];
    $self->{sysLoc} = $sysLoc;
    bless ($self, $class);
    $debug .= "new class has been run<br>";
    return $self;
[download]

where I have fixed the tokens hash key and gooten rid of @orig_args, as you don't use it.

It is traditonal to denote filehandles using capitals (THIS vs this) to avoid collisions with lowercase subroutines and keywords.
In the constructor, you create $self->{tokens} as an anonymous array, but in ParseData, you assign to a hash. You instead probably want something like
```
$self->{tokens} = {};  # in new()
my %tokens = %{ $self->{tokens} };  # in ParseData()
[download]
```

-Mark

In reply to Re: Perl Modules by kvale
in thread Perl Modules by eNtropicChild

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.