The idea is interesting, but the execution is lacking. I am uncomfortable with the caller having to remember to assign to $out in order to get a value into the cell. In fact, I don't really see what you gain by taking a sub reference instead of a string. (If taking the reference has an advantage, why not check the type of parameter, and handle
both?)
I am even more unhappy with the method you use to pass in the table parameters. It's an array, which you interpolate in the print. But if it's not passed, you assign it an empty string! If $st is an empty string, what is $st->[2] ?
IMHO, you should use a hash instead of an array, and check all the values passed in - then only fill out those attributes of the table which have the attribute set.
And to the same for the row and cell, of course - people often need to set their attributes.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.