Like gjb said: it's not a good idea to do one replacement at a time. Why not do them all at once? It'll probably be faster too, as it wouldn't require recompiling the regex again for every substitution — 26 per sub call. You do have the hash you'd need, already. 
  my $pattern = join "|", map quotemeta, keys %key:

  sub decode {
      $$message->{body} =~ s/($pattern)/$key{$1}/og;
  }

[download]
The initialization must have run before you call the sub for the first time — but that's no different from the situation like you already had, for the hash.

Note that you can't have case insensitive searches this way, or the hash entry for the matched string may not exist — though that's easily fixed. But, it doesn't seem to be necessary anyway.

For the other way around, you'll need a reverse hash.

An alternative, which will be faster in most cases, is to use the module Regex::PreSuf. That's a module to construct a regex (as a string) out of a word list. At least the most recent version takes care of the quotemeta itself. 

  use Regex::PreSuf;
  my $pattern = presuf(keys %key);

[download]
Nothing else needs to change. For your case, the pattern ends up looking like: 
  [\^\~\@\!\#\$\%\&\(\)\*\+\-0123456789\\\=\|]

[download]
which is rather nice.

In reply to Re: problematice metashar regexp by bart
in thread problematice metashar regexp by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.