You have the prepare and execute inside the loop commented out, and only the one outside the loop is active.

Whoa! I just realized the prepare statement in the loop overwrites the $sth you use for fetching. Use another name for the handle, like $ins.

Incidentaly, you could move the prepare statement before the loop, if you did it like this:

$sql="INSERT INTO email (f_name, l_name, code, ext, email) 
                VALUES (?, ?, ?, ?, ?)"; 
$ins=$dbh->prepare($sql);

[download]
and replace the execute with 
$sth->execute($FNAME, $LNAME, $STR, $CT5, $EMAIL) || die $sth->errstr;

[download]
Not only is that more maintainable (IMHO), but it should also be faster, since it only has to parse the SQL statements once. In addition, it protects you from things like single quotes in your input.

In reply to Re: INSERT Problem by matija
in thread INSERT Problem by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.