Roy Johnson,
I understand it is un-tested, so some nits:
- When you call the output_summary sub, you need to use () as a suffix or & as a prefix unless it has been previously seen.
- You forgot to chomp newlines
- ++$rowcount not +$rowcount
- ++$ec{$e} not ++%ec{$e}
- $min and $max need to have initial values prior to doing numerical comparisons
Finally, I don't think it is working correctly - shouldn't the max for :20 be 4.151?.
Here is my stab at it:
#!/usr/bin/perl
use strict;
use warnings;
my %data;
while ( <DATA> ) {
chomp;
my ($stamp, $reading) = split;
next if ! $stamp || ! defined $reading;
$data{$stamp}{COUNT}++;
$data{$stamp}{MAX} = $reading if ! defined $data{$stamp}{MAX} || $
+reading > $data{$stamp}{MAX};
$data{$stamp}{MIN} = $reading if ! defined $data{$stamp}{MIN} || $
+reading < $data{$stamp}{MIN};
$data{$stamp}{SUM} += $reading;
}
print join "\t" , "TIMESTAMP", "MAX", "MIN", "AVG";
print "\n";
for my $stamp ( sort keys %data ) {
print join "\t", $stamp, @{$data{$stamp}}{ qw(MAX MIN) }, $data{$s
+tamp}{SUM} / $data{$stamp}{COUNT};
print "\n";
}
L~R
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.