Others have pointed out what is wrong with your code. Some have suggested interpolating the array, which I think is a good strategy here.

However, I haven't seen ?: in this thread yet. Which is strange, as all this if/elsif/... thing seems to do is assign to $from.

my $from = "@movement" eq '0 1' ? 'north' : "@movement" eq '1 0' ? 'east' : "@movement" eq '0 -1' ? 'south' : "@movement" eq '-1 0' ? 'west' : die "Unknown direction: (@movement)";

I probably wouldn't use a lookup hash here. Redundancy's not so bad with only 4 items.

Juerd # { site => 'juerd.nl', plp_site => 'plp.juerd.nl', do_not_use => 'spamtrap' }


In reply to Re: Strange "Useless use of constant" message: should not appear at all! by Juerd
in thread Strange "Useless use of constant" message: should not appear at all! by muba

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.