Predeclaring arrays isn't generally necessary -- there's a bit of a performance benefit as dynamic memory allocation isn't necessary, but Perl handles that sanely anyway.

Caveats aside, save a few characters: my @x = ( 0 ) x 25;

This construct could also be more concise:

while(defined(my $line = <FILE>)) { next if ($line =~ /#.*?,/); my @units=split(/,/, $line); for ($i = 0; $i <= 23; $i++) { if ($line =~ /$xcounits[$i]/) { $y[$i]++; $ytot++; $x[$i] += $units[5]; $xtot += $units[5]; } } }
The defined is in there just in case. (I believe the magic <FH> read does this for you, but I don't have time to look up to make sure assigning to a variable explicitly does.)

The regex could be less cautious. If you want to skip comments, it's a lot easier just to do next if $line =~ /^#/;.

The loop there makes me wonder if you're better off with a hash. Anytime you find yourself looping through an array, looking for a particular element, you should ask if a hash would be more appropriate.

Looks like your next hurdle is learning some Perl idioms to make your life easier. Don't worry, they make more sense once you use them a few times.

Update: moen is right, so I fixed that little issue. Thanks!


In reply to RE: Thoughts from a newbie by chromatic
in thread Thoughts from a newbie by entr00pi

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.