First impression, since your hash keys are the same as your column names, you might want to replace

while(@results = $sth -> fetchrow_array)
{
  $index++;
  $SearchResults[$index]{'id'} = $results[0];
  $SearchResults[$index]{'searchterm'} = $results[1];
  $SearchResults[$index]{'magazinetitle'} = $results[2];
  $SearchResults[$index]{'issueno'} = $results[3];
  $SearchResults[$index]{'startpage'} = $results[4];
  $SearchResults[$index]{'endpage'} = $results[5];
  $SearchResults[$index]{'buynow'} = $results[6];
  $SearchResults[$index]{'index'} = $index;
  $SearchResults{'count'} += 1;
}

[download]

with

{
  my $i = {};
  @SearchResults = @{$sth->fetchall_arrayref($i)};
  $SearchResults{count} = ++$#SearchResults;
}

[download]

...just 'cuz I'm guessing DBI's faster than you are. ;-)

Looks like you could hoist a bunch of stuff out of those loops in your subroutines, too. But as I see ".asp" which stands for "Ain't Stuff for Petruchio", I'll leave that to the smarter monks... many of whom will doubtless tell you to use strict, by the way.

In reply to Re: Help required to improve code by Anonymous Monk
in thread Help required to improve code by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.