If you want people to comment on your code, and you want to receive tested code back, please provide some test data for your script - it's hard for people to guess your input data.

Some things I noticed:

• Why do you open a specific file in the script (with hardcoded pathnames)? Why not just make the script a filter and read from STDIN, and pipe the file (e.g. with "cat" under UNIX, or "type" under Win32) onto the script? That way you won't have to change the script when the location of your data changes.
• You should not hardcode the "23" in the for loop - that should be "@xcounits" (which will yield the number of entries in the array because of scalar context). Neither should you hardcode the "5" and the "0" in the references to "@unit".
• The structure of your indentation looks weird to me - but that's a matter of taste, too. Anyway, I think you should indent the body of "coreport()".

Christian Lemburg
Brainbench MVP for Perl
http://www.brainbench.com

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.