I would start by saying that you should get familiar with
strict and
my. Walk through some
random
tutorials, see if you can find other things to clean up.
For instance while reading from the database you could try
something like this:
while (my $row = $sth->fetchrow_hashref) {
push @SearchResults, $row;
}
Does the same thing you are already doing, but it is
faster, easier to read, less room for error.
In general though, your code is at the point where you need
to work more on pushing the work down to Perl, factoring
out common strings, etc. The biggest win is in readability,
and maintainability, but generally performance will
improve as well.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.