Just a few general style comments. First, get into the habit of starting your programs with:
use strict;
at least until you understand when not to use it. I have not seen Lemay's book, but I trust it has a good explanation of
use strict -- if not, discard it immediately. Second, drop the awful Perl-4 style:
&initarg;
function calling syntax and use the modern style:
initarg();
Third, lexicals are good. So replace:
foreach $i (@_) {
with:
foreach my $i (@_) {
Again, I trust Lemay describes why lexicals should generally be preferred to globals.
Like the others, I recommend switching to
learning perl. See
merlyn's blog entry for an interesting example of a Perl beginner learning Perl in public from merlyn's excellent introductory work.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.