The elements of @lines has newlines. You either need to chomp them:

chomp(my @lines = <FILE>)

In which case you print them with:

print FILE for @lines; # or, to be more verbose foreach my $line (@lines) { print FILE $line }

Or, you can leave off the chomp, and use the loop:

print FILE "$_\n" for @lines; # or, to be more verbose foreach my $line (@lines) { print FILE "$line\n"; }

Either you've removed the newlines or you haven't, your foreach loop has to match.

Of course, if this is all you're doing with @lines it'd be much simpler, and more kind to memory, to just read and write at the same time:

print OUTPUT_FILE while <INPUT_FILE>; # or, to be more verbose while ($line = <INPUT_FILE>) { # manipulation of $line goes here. print OUTPUT_FILE $line; }

perldoc -q 'entire file' covers this topic, 5.6.1's perldoc -q 'line in a file' helps to explain dealing with files, and 5.8.4's perldoc -q 'line in a file' tells you to use Tie::File.


In reply to Re: Re: Re: reading file into an array by Somni
in thread reading file into an array by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.