Well one step to simplifiy that would be to use selectall_array($sql, {Slice => {}}) and then one of your subs becomes: 

sub _getBuilderList {
        my $self = shift;
        my $selection = shift;
 
        my @cities = $self->param('DBH')->selectall_array("SELECT id, 
+buildername FROM builder ORDER BY buildername", {Slice => {}} );
        @cities = grep { $_->{SELECTED}++ if $_->{id} == $selection; $
+_ } @cities;
        return \@cities;
}

[download]
Something along those lines at least. Then you see your just passing a SQL statment and you have a condition for selection. I'm not sure if if can be reduced any but this is a nice reduction so far.


___________
Eric Hodges

In reply to Re: abstraction -- level up! by eric256
in thread abstraction -- level up! by geektron

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.