The comments above suggest that you cut out the repeated database connections. This code might be a good place for you start:
sub dbi_connect { my $self = shift; return $$self{dbh} ||= DBI->connect($dbi,$u,$p,{'RaiseError' => 1}); } sub dbi_disconnect { my $self = shift; return 1 unless $$self{dbh}; my $dbh = $self->dbi_connect; $dbh->disconnect || die $dbh->errstr; $$self{dbh} = undef; return 1; }
Obviously you should only call dbi_disconnect when you are finished with the db handle. Alternatively just let it get disconnected automatically when the object goes out of scope.

--tidiness is the memory loss of environmental mnemonics


In reply to Re: Avoiding too many DB queries by EvdB
in thread Avoiding too many DB queries by seaver

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.