In addition to the other comments, I think when you're getting the state setting from the form, you mean to say $FORM{state}; you currently say $FORM{$state}, and since $state isn't defined yet, you're looking at $FORM{''}. Using warnings would have told you that, BTW.

And I suspect you don't know how to use a lookup table, since this is the perfect application for one. Essentially you would say: 

%states = ( AL => ['AL', 'Alabama'],
            AK => ['AK', 'Alaska'],
...
            SA => ['SA', 'Saskatchewan'],
            YU => ['YU', 'Yukon Territory'],
);
if (my $st = $states{$FORM{state}})
{
  ($state,$statename)=@$st;
}
else
{
  die "Invalid state!"
}

[download]
As you can see, the code is much cleaner and easier to maintain, and will also be marginally faster in most cases.

In reply to Re: Untaint variables not working, IF statements. by sgifford
in thread Untaint variables not working, IF statements. by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.