Monks,

I come seeking your opinions on this subroutine, it takes a reference to a scalar holding the name of the client, and a reference to a hash of db login properties. It then constructs the gui by creating a hash of arrays to hold corresponding elements.... lemme know what you think.. is it overly verbose.. or does it add to maintainability. 

sub guiStart
{
    my ($client,$login) = @_;
    
    my $mw = MainWindow->new(-borderwidth=>30,
                             -title=>"Duplicates: ".$$client);

    my %layout = ('frame'   => [],
                  'button'  => [],              
                  'label'   => [],
                  'callback'=> []);
    
    #Construct labels 
    $layout{'label'}->[0] = 'List Available Data';
    $layout{'label'}->[1] = 'Remove Data';
    $layout{'label'}->[2] = 'Add Data';
    $layout{'label'}->[3] = 'Identify Duplicates';
    $layout{'label'}->[4] = 'Change Client';
    $layout{'label'}->[5] = 'Exit Application';
    
    #Set callbacks
    $layout{'callback'}->[0] = \&listData;
    $layout{'callback'}->[1] = \&removeData;
    $layout{'callback'}->[2] = [\&addData,,$client,$login,$mw];
    $layout{'callback'}->[3] = \&identifyDuplicates;
    $layout{'callback'}->[4] = \&changeClient;
    $layout{'callback'}->[5] = \&exitApp;            
    
    for (0..5)
    {
        #Create the frames
        $layout{'frame'}->[$_]  = $mw->Frame();
    
        #Create the buttons
        $layout{'button'}->[$_] = $layout{'frame'}->[$_]->Button(-text
+   =>$layout{'label'}->[$_],
                                                                 -widt
+h  =>20,
                                                                 -comm
+and=>$layout{'callback'}->[$_])->pack();
        $layout{'frame'}->[$_]->pack();
    }
    
    MainLoop;
    
    return;
}

[download]
Grygonos

In reply to GUI Setup with Tk, overly verbose, or maintainable? by Grygonos

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.