Can anybody shed any light on this?

Not directly, but there are a couple of issues that leap out at me.

  if ($token->[0] eq "S" and ${$token->[2]}{year}){ $year = ${$token->
+[2]}{year} }
      if ($token->[0] eq "S"){
[download]

Those two statements are actually at the same level. Despite what the indentation says, the latter is not subordinate to the former. Bring the second back to the same indentation level as the first, or, better yet, rearrange the code to say $token->[0] eq "S" only once.

The variable $temp raises an immediate Red Flag. Name it $token instead, because that is what it appears to be.

Declare your variables as late as possible. By pulling $temp/$token into the inner loop, and above all, $info, you don't need the make-work $info = {}, it will be automatically reset each time through the loop.

Drop the & on the function calls.

The following code:

    $temp = &get_token("a");
    if ($temp eq " "){
        $info->{email} = '';
    }
    else{
        $info->{email} = $temp;
    }
[download]

... could greatly benefit from the ternary ? : operator:

    $token = get_token("a");
    $info->{email} = $token eq " "
        ? ''
        : $token
    ;
    # update: had a mish-mash of temp/token in this snippet
[download]

... not because using the ternary operator is cool, or for some other bogus style reason, but because it means that you only say $info->{email} once, which means one less chance of typing or editing a key incorrectly and thereby creating two keys in the hash.

The following code, um, needs attention:

    my $t2;
    ($info->{city}, $t2) = split(', ',$temp);
    ($info->{state},$t2) = split(" ",$t2);
    $t2 =~ s/\s+//;
    $info->{zip} = $t2;
[download]

It looks like an abuse of split (if you have is a hammer...) A regex can do the same in a single statement, with no need for the intermediate variable (which has a horribly unhelpful name anyway). I'm not sure about the following, but something like this will work:

    @{$info}{qw{     city       state   zip}} =
        ($token =~ /^([^,])+,\s+(\S+)\s+(\d+)$/)
            ? (      $1,        $2,     $3     )
            : (      '',        '',     ''     )
    ;
[download]

Now that's definitely fancy stuff, but it's just taking the previous points into consideration and throwing in a hash-slice assignment. And with a bit of creative whitespace we can make things line up and the code documents itself quite nicely.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.