You probably need, for one thing, to pass the typeglob, not the bareword filehandle. I understand the prototypes, but they need to come before the sub is ever called... and prototypes are an ugly world anyway. Even better, pass a lexical just as you would if you said, "open my $fh, $filename or die $!;".

And next, you should probably be using the three arg version of open. That's safer.

And next... you should probably die instead of just returning if you fail to open the file. Currently, when you fail to open the file, you'll never know why. You could die, print $! for details on why you failed.


Dave

In reply to Re: Trouble making my own open()-like routines. by davido
in thread Trouble making my own open()-like routines. by William G. Davis

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.