CGI.pm considered painful and ugly.

HTML generating methods considered very slow.

td and Tr considered hard to read.

Nested maps considered harmful for maintainer's brain.

Considering considered a waste of time :)

But I think you're not thinking of ever maintaining this code anyway. The one-letter variables (typing "key" instead of "k" will not give you RSI), big indentation levels, hardcoded colour codes and sequential building of HTML give that away. I'm guessing that somewhere in your code is something like $html = read_file('header.html');, or worse: $html = $q->start_html; (if it is a string literal, please let someone strangle you).

Just store your data as an array of arrays, or something alike, and use a simple module to write the table for you. Or at least move the html-generating things out of the way of anything that deals with raw data.

Templating modules considered mandatory.

Juerd # { site => 'juerd.nl', plp_site => 'plp.juerd.nl', do_not_use => 'spamtrap' }

In reply to Re: CGI.pm HTML-Generation Methods Considered Useful by Juerd
in thread CGI.pm HTML-Generation Methods Considered Useful by friedo

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.