Because a common idiom used to "solve" the "class or object method?" question, can lead to odd behavior when a constructor is called as a function and not a method.
I disagree:

How can you disagree with it? Your script proves it. Does not bless {}, ref($class) || $class lead to odd behavior when called as a function (specifically being blessed into main::). Sure it does, and the same goes for bless {}, shift, but that only tells me that both are (maybe) bad, not just bless {}, ref($class) || $class.

To be honest, I am confused by your argument here. You are comparing bless {}, ref($class) || $class with bless {}, shift, saying that they have the same behavior when called as a function and not a method. I agree with that, I have never disagreed. I didn't bring that second idiom up, you did, and in the end, I just see it as having the same problems as the first idiom.

I don't think I ever said that "class or object" is the only possible cause of the odd behavior, it is one of them. And I am not sure why you seem to be implying that bless {}, ref($class) || $class and bless {}, shift are my only (?) two options. I guess I am just not understanding what you are trying to say.

My original point was that practices like bless {}, ref($class) || $class (which includes bless {}, shift) are not really the best since they can create a problem when constructors are called as functions (accidentaly or on purpose).

What leads you to believe otherwise?

I don't believe otherwise, I believe that not checking the specifics of $class is (in some cases) bad no matter how you do/don't it.

-stvn

In reply to Re^8: Is "ref($class) || $class" a bad thing? by stvn
in thread Is "ref($class) || $class" a bad thing? by stvn

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.