Hi,

I'm having some trouble uploading a file from a web page form.
The form submits and creates the file, but the file is 0 bytes.
I'm using Perl 5.8.4, CGI and Apache2 on FC1. The same script was working with Perl 5.6, CGI and Apache1 on RH7.2...
Here's my code:
my $error = undef;
my $directory = "./tmp/";
my $filename = $q->param("filename");
my $origfile = $filename;
$filename =~ s/^.*[\\\/:]//;

if ( open(OUTFILE,'>'.$directory.$filename) ) {
  binmode OUTFILE;
  my $bytesread;
  my $buffer;
  while ( !$error && ( $bytesread = read ($origfile,$buffer,4096) ) ) 
+{
    if ( !(print OUTFILE $buffer) ) {
      $error = 'Could not save uploaded file';
    }
  }
  close OUTFILE; 
  } else {
    # error <- file creation error
    $error = 'Could not create file';
  }
close($filename);

[download]
Anyone have any ideas?

Cheers,
Reagen

Note I have replaced the instance of attachfile with filename

Update I have just found I am getting "read() on unopened filehandle at line..." (the line where it reads) in the apache log.

Solution I found the solution. I had my upload script in a sub and this is how i was calling it:
my $filename = $q->param("filename");
&uploadFile("$filename");

[download]
When i removed the "s from the sub line 
&uploadFile($filename);

[download]
it worked. dont know why.

In reply to File Upload by rsiedl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.