Is there some reason for not putting the "grouping" code in a subroutine?

My personal bias would be to scope the array over a pair of subroutines that playe with it

    ...
    if ( @sub_list > 1 )
      {
        # maybe lots of code here to build the record,
        # using all those attributes... 
        add_record(# some record );
      }
    ...
    if ( @sub_list > 1 )
      {
        # maybe lots of code here to build the record,
        # using all those attributes... 
        add_record(# some record );
      }
    ....

{
    # Private scope for various things
    my @complete_list = ();

sub add_record
  {
    my($record) = @_;
    ...
    push @complete_list, $record;
  }

sub find_record
  {
    my($index) = @_;
    # Do some checking for validity
    return $complete_list[$index];
  }

# End the private scope
}

[download]

In reply to Re: Looping and Grouping: there must be a better way! by hawtin
in thread Looping and Grouping: there must be a better way! by edan

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.