Thanks for directing me in the right direction. The problem was indeed the $i reference. Also I had a mistake in my right statement. The correct algorithm to generate right and left ids for a hierarchical tree should be: 


my $root =1;
my $counter = 1;
rebuild_tree($root);

sub rebuild_tree{
my $idy = shift;

my $result= $dbh->prepare("SELECT id FROM terms WHERE parent_id = ?");
my $left = $dbh->prepare("UPDATE terms SET left_id=? WHERE id = ?");
my $right= $dbh->prepare("UPDATE terms SET right_id=? WHERE id = ?");


$left->execute($ctr++,$idy);
$result->execute($idy);
  while (my $i = $result->fetchrow_hashref()) {
  rebuild_tree($i->{id});
  }
$right->execute($ctr++,$idy);

}#end of sub

[download]
The only way I could get it to work is by inserting the prepare handles in the sub.

In reply to Re^3: Hierarchical Tree Traversal by Raad
in thread Hierarchical Tree Traversal by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.