Someone already pointed out that you need to define your dispatch table a little differently. Your example is creating a hash of scalar references, instead of a hash of subrefs. I won't belabor that point since it's already been made.

I did want to mention that your dispatch table needn't use named subs at all. Consider the following code: 

my %dispatch = ( 
    DoThis => sub { print "You asked me to do this.\n"; },
    DoThat => sub { print "You asked me to do that.\n"; }
);

[download]

For trivial subs, defining them inline like this can be a simple, convenient, and readable solution.

Another solution is the switch construct: 

SWITCH: for ( @commands ) {
    m/^This/ && do { print "You asked me to do this.\n";
                     next SWITCH;
                   };
    m/^That/ && do { print "You asked me to do that.\n";
                     next SWITCH;
                   };
    m/^Another/ && Another_Way();
    m/^Quit/ && do { print "Goodbye.\n";
                     last SWITCH;
}

sub Another_Way {
    print "You asked me to do it another way.\n";
}

[download]

Of course there are other ways to do it as well... This is Perl after all.


Dave

In reply to Re: menu script by davido
in thread menu script by yoda54

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.