if ( ( $flag1 or $flag2 )
 and ( length( $string ) )

[download]

This is where lining up your delimiters makes a lot of sense. Had you lined up the interior parens, giving 

if ( ( $flag1 or $flag2  )
 and ( length( $string ) )

[download]
the unbalanced leading paren would be a bit more obvious; in fact, 
if ( ( $flag1 or $flag2  ) and
     ( length( $string ) )

[download]
might be even better: the if's leading paren isn't "masked" by the and.

In this case, though, I'd be sorely tempted to break the if's condition out into a small sub with a meaningful name. I think 

if ( &condition( $flag1, $flag2, $string ) )

[download]
is plenty readable, and gives you less punctuation to worry about.

--
F o x t r o t U n i f o r m
Found a typo in this node? /msg me
% man 3 strfry

In reply to Re^3: Grokking Compile Error Messages by FoxtrotUniform
in thread Grokking Compile Error Messages by QM

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.