One thing you can do to earn a few style points but mainly to maximize your use of Getopt::Long is to use a hash. For one thing, it allows you to pass a simple hashref so that you don't end up doing any ugly $main::opt_foo business when you're trying to access your options from another class. And it also makes it easy to have default options.

my %opts = ( 'foo' => 'default_value', 'bar' => 'another_default_value', 'baz' => 'yet_another' ); GetOptions( \%opts, override, default, values, here); My::Class->method( \%opts ); # ... elsewhere in your code ... package My::Class; my $class = shift; my $opts_ref = shift; ...

Also, if you're going to use an anonymous sub for help, it reads a little better if you do:

'h|help' => sub { help() },
then have sub help print out your help text.

--
"A long habit of not thinking a thing wrong, gives it a superficial appearance of being right." -- Thomas Paine
naChoZ


In reply to Re: Getopt::Long good style? by naChoZ
in thread Getopt::Long good style? by Skeeve

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.