There are a few things about your code as posted that seem odd (i.e. not good):
- You open MARKER for output inside the "get_pocus" subroutine, but close it outside the subroutine.
- You connect to the database before going into the while (<LIST>) loop at the end, but disconnect inside the while loop.
- You prepare a statement on each iteration of that while loop with a quoted parameter in the "where" condition, whereas you should prepare the statement before the while loop with a "?" placeholder, and just call "execute" on that statement in each iteration, passing the parameter value to the "execute" call.
Also, it looks like the usage is just a matter of providing a single number between 1 and 10. It would make more sense to have that as a command-line arg:
my $Usage = <<ENDUSE;
Usage: $0 N
where N is a number between 1 and 10:
1 : Alzheimer disease
2 : Bardet Biedl
3 : Breast cancer
...
ENDUSE
die $Usage unless ( @ARGV == 1 and $ARGV[0] =~ /^\d+$/
and $ARGV[0] > 0 and #ARGV[0] < 11 );
my $choice = shift;
...
This way, it's easier to run the script either interactively or from another process, because the information that the script needs from the user is part of the command line.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.