Hello Monks,

I have been learning perl for the last month or so. Having gone through several tutorials writing practice code I decided it was time to try one of my own.

Following is some code that works for removing emacs tmp files and core files generated by the kernel from the /home/john and /lib directories. One of my goals for this is to easily change which directories are parsed.

My question is on the way I setup the parameters to be passed to the subroutine. Is this the correct way to setup multiple arguments for the subroutine? 
#!/usr/bin/perl -w

$user = "/home/john";
$lib = "/lib";

&directs($lib);
&directs($user);

sub directs {
    foreach (@_) {
        opendir(DIRS,$_);
        @tmps = readdir(DIRS);

        closedir(DIRS);
    }
    &remove;
}

sub remove {
    foreach $line(@tmps) {
    if (($line =~ /~$/ ) || ($line =~ /^core\./)) {
    unlink "$line";
        #print "$line\n";
    }
  }
}

[download]


All of these are really good answers. I will start implementing (or learning how to use them) immediately.

One of the reasons that I made this post is to learn the correct way and get into the habit of doing things that way. Fortunately I don't have any bad habits to break since I have never programmed before-I am a network administrator by profession. All of you have supplied me with good habits to get into.

Thank you very much!

John

In reply to using a subroutine by xjlittle

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.