I've recently been handed a project that involves fixing some of the most bletcherous code I've seen thus far in my career, apparently written by a professional perl programmer. Here are some examples, posted for you're amusement ;-)


$content_dem = "$content_dem"."DEM"."\t"."1"."\t"."1"."\n";

#Remove commas $content =~ s!, "?!!gis; @array = split(/"/, $content);

if (system("/bin/cp $temp_cur $final_file")) { printf("Error - file '$final_file' not updated.\n"); exit(-1); }

select STDOUT; $| = 1; open SAVEOUT, ">&STDOUT"; close STDOUT; open STDOUT, ">&SAVEOUT";

Suffice it to say, I would much rather re-write all of this from scratch than have to live with the thought that anyone else would ever have to try and hack / decipher them. Or end up having to work on them again in a couple of months time.

However, it did get me thinking, what's the worst / most bizarre / inexplicable code my fellow monks have come across over the years? I'm sure I'm probably just scraping the tip of the iceberg here (though, having said that, I must confess that the intention of the writer of the last chunk of code is a mystery to me).


In reply to The inheritance of Cruft by kilinrax

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.