I'd combine the if-statements somehow:
my %users = map { $u => 0 } qw/ list of users to watch /; while (1) { my %curr = map { $_ => 1 } split / /, `users`; for (keys %users) { if ( $users{$_} != $curr{$_} ) { $users{$_} = $curr{$_}; printf "%s: $_ has logged %s\n", scalar localtime, ($users{$_} ? "in" : "out"); } } sleep 2; }
But you know, it's much more fun to do something completely off the wall:
use Tie::Scalar; @ISA = (Tie::StdScalar); sub TIESCALAR { bless { k => $_[1], v => $_[2] }, $_[0] }; sub FETCH { $_[0]{v} } sub STORE { $_[0]{v} != $_[1] and printf "%s: $_[0]{k} logged %s\n", scalar localtime, ($_[1] ? "in" : "out"); $_[0]{v} = $_[1]; } my (@list, %user) = qw/ list of users to watch/; tie $user{$_}, main => $_, undef for @list; while (1) { my %curr = map { $_ => 1 } split / /, `users`; $user{$_} = $curr{$_} for @list; sleep 2; }
Hmm.. then again, you did say "readable", didn't you? ;)

blokhead


In reply to Re: Shorten this code by blokhead
in thread Shorten this code by hostyle

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.