If you were running with "use warnings" then Perl would have told you what the problem is. Filehandles aren't first-class variables in Perl so you can't just return a filehandle from a function and assign it to a variable like that. You're actually using the same filehandle (FILE) for both files - which is why you can't use it after you've closed the first filehandle.

You can get round this by using lexical filehandles.

sub openFile {
  my ($file, $accessMode) = @_;
  my $err;

  $accessMode = $MODE_READ unless defined $accessMode;

  if (exists($ACCESS_MODES{$accessMode})) {
    if (open(my $fh, "$ACCESS_MODES{$accessMode}$file")) {
      return $fh;
    } else {
      $err = $!;
      if (defined($returnOnError)) {
        return;
      }
      &throwGenError("Can't open $file: $err");   # throw exception
    }
  } else {
    &throwGenError("In openFile: Wrong access mode &accessMode");
  }
  return;
}

[download]

Some of your logic is a bit scary, so I haven't changed too much. You might need to check it carefully.

--
<http://www.dave.org.uk>

"The first rule of Perl club is you do not talk about Perl club."
-- Chip Salzenberg

In reply to Re: Open file issues by davorg
in thread Open file issues by hotshot

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.