You're completely right of course. The issue with not refactoring is that every error condition is slightly (or, in a few cases, vastly) different. The deadlines are on the order of hours, not days or weeks, and it'll take some thought on how to reorganize the code so that these slight variations can be handled from a few functions. It's not so much fail-and-log or fail-and-die. This is "fail and connect to different db to pull out sensible defaults for unset fields in existing database but only if called in a certain context".

In other words a nightmare. But your point stands that if I can refactor now, the extra ten minutes is probably worth it.

Cheers,
Erik

Light a man a fire, he's warm for a day. Catch a man on fire, and he's warm for the rest of his life. - Terry Pratchet

janitored by ybiC: Replaced "run-on phrase using dashes" with balanced quotes and italics, for to avoid lateral scrolling

In reply to Re^2: A new idiom -or- I Hate Unless by erikharrison
in thread A new idiom -or- I Hate Unless by erikharrison

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.