That's a LOT of code for what seems to be such a minor task. All those files you open and close, do you really need them? Wouldn't simple arrays and hashes and perhaps some Caching be better? I will admit that when i first started Perl, i had a bad habit of looping many times instead of just once or twice. Unrelated to that, one particular item that really bothers me is this: 

my $ref = eval { XMLin($xmlfile) };

#see if open worked
if ($@) {
    print "XML Read ERROR";
} 
else { ... }

[download]
Why are you bypassing the errors reported from XML::Simple in this manner? Seems to me that if the file cannot be parsed then you don't need to be continuing execution. Not to mention that XML::Simple will return meaningful messages as to why the file did not parse. By trapping the die you have no clue as to what went wrong.

Finally, unless you provide some example XML, we can't really try your code out. But i still think you could trim this down to under 40 lines. ;)

jeffa

L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
B--B--B--B--B--B--B--B--
H---H---H---H---H---H---
(the triplet paradiddle with high-hat)

In reply to Re: Extracting xml data and using them for SNMP by jeffa
in thread Extracting xml data and using them for SNMP by theroninwins

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.