Hi.

I wrote a small index file for a website, it should read the contents from html files, and print them inside of a template.

what I'm concerned with is if the actual file passing method is secure enough:

this is what I have: 

my $req = $ENV{QUERY_STRING};

$req =~ s/^.*\///;
$req = 'index' if -e $req;

my $page = "pages/$req.html";

$page = "pages/index.html" unless -e $page;

[download]

the pages are inside a pages/ folder, and the request is such that index.pl?about will give me the about.html page.

do you see any security flaw with this method? like being somehow able to go back in folders and read stuff you shouldn't be reading?

thank you.

In reply to request for review: file reading security by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.