It isn't only the security. Your line $req = 'index' if -e $req; will make all requests invoke "index". Your code means " assign to 'index' if a file named $req exists". I am not sure what you wanted to achieve that way, but here is how I would do it.

use strict;
use warnings;

my $req = $ENV{QUERY_STRING};

# limits the applicability. Only lowercase file names
$req = lc $req;

# remove all unwanted characters from the beginning of the 
string. # In this example, everything except alphanumerics
# and underscore is removed.
$req =~ s/^[^a-z_0-9]+//;

# remove an extension, if any
$req =~ s/\.html$//;

# default value is the index
my $page = "pages/index.html";

# if the page exists, then we use it
$page = "pages/$req.html" if  -e "pages/$req.html" ;

[download]

Also, consider using CGI param instead of reading the environment.

HTH

In reply to Re: request for review: file reading security by cchampion
in thread request for review: file reading security by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.