A couple of things,

  • Use Strict.
  • Your cgi does not actually protect anything, users can bypass the auth.
  • The site that you redirect to needs to be fixed. you generate a filename based on the input of the date, a savvy user can push their own date param and write files at the location of their choice (see example output of ///../ in the date field below, although more complex paths can be entered ).
  • Also you need to change the error output of your web server to hide details such as this: 
    Software error:

Cannot Open File /usr/local/httpd/virtuals/elghome/ips/www.elgin.lib.i
+l.us/bob/.txt for writing: Permission denied at /usr/local/httpd/virt
+uals/elghome/www.elginarea.org/cgi-bin/bobweb.pl line 116.



For help, please send mail to the webmaster (elghome@nsn1.northstarnet
+.org), giving this error message and the time and date of the error.

    [download]


    -Waswas

    In reply to Re: Param not working correctly by waswas-fng
    in thread Param not working correctly by Midnite

    Title:
    Use:  <p> text here (a paragraph) </p>
    and:  <code> code here </code>
    to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.