Interesting post.

Any time I see something like 

if ( $x and !$y ) {
  .. # true, false
} elsif ( !$x and $y ) {
  .. # false, true
} else {
  .. # true, true or false, false
}

[download]
warning bells go off because I wonder if it could have been written as 
if ( $x ) {
  if ( $y ) {
    .. # true, true
  } else {
    .. # true, false
  }
} else {
  if ( $y ) {
    .. # false, true
  } else {
    .. # false, false
  }
}

[download]
instead. Granted, this may not be required much of the time, but it sure makes code maintenance a year later a little easier.

Alex / talexb / Toronto

"Groklaw is the open-source mentality applied to legal research" ~ Linus Torvalds

In reply to Re: "if" Considered Harmful in OO programming by talexb
in thread "if" Considered Harmful in OO programming by Ovid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.