Hey all- here is the code... it is pretty sloppy i am sure, but it is also my first time. Perl is still very new to me.

#!/usr/bin/perl -w print "What is input file name?: "; chomp($input = <STDIN>); print "What is output file name: "; chomp($output = <STDIN>); print "What is the mininum magnitude?:"; chomp($min_mag = <STDIN>); print "What is maximum magnitude?:"; chomp($max_mag = <STDIN>); open (INPUT, "$input") || die "died opening input\n";#opening up ngc18 +8cata and putting it into INPUT# open (STDOUT, ">$output") || die "died opening output\n"; #opening up +ngc188cat2 and setting output of out# $cfo = "O"; $status = "STATUS=OK"; open OUT, "+<holder"; while ($inline = <INPUT>) { #INPUT defined as variable# @mag = split(/\s+/, $inline); #firstline of array defined by split of + white space into variable inline# if ($mag[12] >= $min_mag && $mag[12] <= $max_mag) { print OUT "$inline"; #printing to OUT } } close OUT; open NEW, "+<holder"; while ($sep = <NEW>) { @firstline = split(/\s+/, $sep); $hms1 = $firstline[2]; $rah2 = ($hms1 / 15); $rah3 = int($rah2); $ram1 = ( abs($rah2 - $rah3) )* 60; $ram2 = int($ram1); $ras1 = abs($ram1 - $ram2) * 60; $ras2 = sprintf "%-02.3f", $ras1; ############################################ $hms2 = $firstline[3]; $hh2 = sprintf "%1d", ($hms2); $mm2 = sprintf "%02d", (60*( abs($hms2) - abs($hh2) ) ); $ss2 = sprintf "%-02.2f", 3600*abs($hms2) - 3600*abs($hh2) - 60*abs($ +mm2); ############################################################ $obid = "NGC 188 - $firstline[1]"; ########################################################### write; #writing to STDOUT } close INPUT; close NEW; format STDOUT = @>>> @<<<<<<<<<<<<<<<<<<< @> @> @>>>>> @< @< @>>>> @ @<<<<<<<< $firstline[1], $obid, $rah3, $ram2, $ras2, $hh2, $mm2, $ss2, $cfo, $st +atus, .
Just to explain how i thought about this. The information is ran through the first loop, containing the "if" statement, which takes out the information I want. From there, that information is put into a seperate external file. That external file is then opened and ran through a second loop, which gives me the information i need, that is subsquently formatted into a data report.

So what i am wondering is how i can clean up the loops, or if it is possible and easy combine the two loops that I have in order to make just one loop? I would perfer to not have an external file ("holder") if at all possible. I would appericate some help, because I am going to have to make some more if loops like this, asking to examine different elements in the original dataset instead.

Thank you! srkaeppler


In reply to Making two loops into one by srkaeppler

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.