Erg, teach me to start optimising in the most stupdi places. I have modded my code to loop like yours, and moved my hash creation outside the inner loop (what a dummy!) and ditched the sub (which was mostly there for clarity, anyway). Then we get:
my $out;
for my $i (0 .. $#lines) {
my %words1 = map { $_ => 1 } split /_/, $lines[$i];
for my $j($i + 1 .. $#lines) {
if (1 < grep $words1{$_}, split /_/, $lines[$j]) {
$out .= "$lines[$i] and $lines[$j]\n";
}
}
}
$out;
Faster! Benchmark:
Benchmark: running bmann, jasper, rev for at least 3 CPU seconds...
bmann: 3 wallclock secs ( 3.17 usr + 0.00 sys = 3.17 CPU) @ 88
+28.71/s (n=27987)
jasper: 3 wallclock secs ( 3.15 usr + 0.00 sys = 3.15 CPU) @ 10
+860.32/s (n=34210)
rev: 3 wallclock secs ( 3.17 usr + 0.00 sys = 3.17 CPU) @ 22
+06.94/s (n=6996)
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
|
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.