You previously mentioned a Speedtrap has 1:N Comments. Given that, your question does not provide enough information about what you want.
- Do you want to display all the Speedtraps, and list only Comments that match the query;
- do you want to display only the Speedtraps with comments that match the query, but list all the Comments; or
- do you want to display only the Speedtraps with comments that match the query, and only the Comments that match the query?
btw, here's a trick to simply your if:
$query = 'WHERE 1=1';
$query .= " AND state='$state'" if ($state ne 'all');
$query .= " AND approved='$status'" if ($status ne 'all');
Also, as I mentioned before, escape your arguments!! Unless you want someone to inject a query that deletes or modifies your database... Use replaceable parameters (as shown previously) or use quote(), as shown here:
my $q_state = $dbh->quote($state);
my $q_status = $dbh->quote($status);
$query = 'WHERE 1=1';
$query .= " AND state=$q_state" if ($state ne 'all');
$query .= " AND approved=$q_status" if ($status ne 'all');
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.