Looks good. The if is a bit shaky, and I don't mean the one you think:

if ($possible) {
  $average = sprintf("%2.2f", ($earned / $possible) * 100);

  if    ($average >= 95) { $grade = "A";  }
  elsif ($average >= 90) { $grade = "A-"; }
  elsif ($average >= 87) { $grade = "B+"; }
  elsif ($average >= 84) { $grade = "B";  }
  elsif ($average >= 80) { $grade = "B-"; }
  elsif ($average >= 77) { $grade = "C+"; }
  elsif ($average >= 74) { $grade = "C";  }
  elsif ($average >= 70) { $grade = "C-"; }
  elsif ($average >= 67) { $grade = "D+"; }
  elsif ($average >= 64) { $grade = "D";  }
  elsif ($average >= 60) { $grade = "D-"; }
  elsif ($average <  60) { $grade = "E";  }

} else {

  $grade = $average = $earned = $possible = "?";
}

[download]

One way to get rid of the big if:

@GRADES   = qw( E  D- D  D+ C- C  C+ B- B  B+ A- A  );
@BRACKETS =   (    60,64,67,70,74,77,80,84,87,90,95 );


if ($possible) {
  $average = sprintf("%2.2f", ($earned / $possible) * 100);

  $grade = 0;
  foreach (@BRACKETS) { $grade++ if ($average >= $_); }
  $grade = $GRADES[$grade];

} else {

  $grade = $average = $earned = $possible = "?";
}

[download]

And how about only preparing the query only once:

# prepare query
$cursor = $dbh->prepare('SELECT * FROM grades WHERE className=?');

# cycle through courses
foreach $course (@courses) {

  # execute query
  $cursor->execute($course);

  ...
}

...

[download]

In reply to Re: Efficiency of code by ikegami
in thread Efficiency of code by Futz

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.