• Use CGI's param method to do the parsing of input. Your code fails on a GET method.
  • Define a limit on how much data you are willing to accept, or the CGI will happely eat as much data as a client is willing to feed you.
  • Use DBI place holders. This will take care of quoting, and (baring unrevealed bugs in the DBI) eliminate all possible SQL injection hacks.
  • Don't use "false" values in your database to signal anything special. That's what NULL values are for. (Note that in your code, you will insert "false" even if the client has set a value to "0", or an empty string).
  • Don't go formatting your own dates to stuff them into the database - use your databases' timestamp feature. And if you need to format times for something else, just use POSIX::strftime. Your entire block of code to format the date could have been written as: 
    use POSIX;
$date = POSIX::strftime("%A, %B %e, %Y at %T", localtime);

    [download]

    In reply to Re: Hacker Proofing My First Script by Anonymous Monk
    in thread Hacker Proofing My First Script by awohld

    Title:
    Use:  <p> text here (a paragraph) </p>
    and:  <code> code here </code>
    to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.