You can't just add my to each first occurrence of each variable in a script and expect the script to work properly after that. What if the script has something like this? 

foreach $thingy ( @lots_of_thingies ) {
    $all_of_them .= $thingy;
}
print "$all_of_them\n";

[download]

In that example, if $all_of_them is declared with my in the lexical scope bounded by the foreach loop's code block, you won't be able to print it after the loop runs out.

strict enforces not just the use of variable declaraction, but it requires that additional thought be paid to design of lexical scopes. The OP would be wise to read perlintro, perlsub, perlsyn and my for starters. Sometimes a script is just beyond converting to compliance with strictures unless one is willing to take the time for a major rewrite.


Dave

In reply to Re^2: How to correct code by davido
in thread How to correct code by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.