Given the simplicity and regularity of your ranges, you could simply compute indices of a two-dimensional array instead, like this:
use strict; use POSIX qw(floor); my $input = $ARGV[0]; open(FILE, $input) || die "ERROR: Unable to open $input FILE for readi +ng: $!\n"; my @range2; my ($phi, $psi); while (<FILE>) { $phi = substr($_, 0, 6); $psi = substr($_, 8, 6); print "$phi $psi\n"; my $i = floor($phi/5.0) + 36; my $j = floor($psi/5.0) + 36; if ($i >= 0 && $j >= 0 && $i < 73 && $j < 73) { ++$range2[$i][$j]; } } for my $i (0..72) { for my $j (0..72) { my $val = $range2[$i][$j]; $val ||= 0; print "$val, "; } print "\n"; }

In reply to Re: inefficient code? works on small files ok but not larger ones by tall_man
in thread inefficient code? works on small files ok but not larger ones by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.