First, you hardly ever need an extra counter when you loop in Perl. That is a hold over from other languages, i had the same bad habit myself when i started Perl. Second, since you know which <trans> you want, the one with kool="kool", then you don't need to worry about counting them: just "ask" for the <trans> tag with attribute kool that is set to "kool". Third, use the right tool for the right job. In this case, XML::Twig is the Vorpal Blade you seek:

use strict; use warnings; use XML::Twig; my $twig = XML::Twig->new(pretty_print => 'indented'); my $data = do {local $/;<DATA>}; $twig->parse($data); my $root = $twig->root; my @trans = $root->children; for my $trans (@trans) { next unless $trans->att('kool') eq 'kool'; my $item = XML::Twig::Elt->new(item => { id => 'maxis'}); my $assignee = XML::Twig::Elt->new(assignee => 'Jill') ->paste(last_child => $item); my $status = XML::Twig::Elt->new(status => 'con') ->paste(last_child => $item); $item->paste(last_child => $trans); } $twig->print; __DATA__ <opt> <trans kool="max"> <item id="legas"> <status>contacted</status> <assignee>jack</assignee> </item> </trans> <trans kool ="kool"> <item id="gas"> <status>contacted</status> <assignee>jack</assignee> </item> </trans> </opt>
See? No need for an extraneous counter, the next unless $trans->att('kool') eq 'kool'; line will skip all <trans> tags that do not have an attribute named kool set to "kool".

jeffa

L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
B--B--B--B--B--B--B--B--
H---H---H---H---H---H---
(the triplet paradiddle with high-hat)

In reply to Re^3: Add new elements with XML::Simple by jeffa
in thread Add new elements with XML::Simple by Maxim

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.