You are not passing a CGI object all. You're counting on the $cgi variable being a package variable in package main. This won't work when someone uses a lexical $cgi variable, or just any other variable name.

Since you're obviously worrying about security, I wonder if you're using the $:: prefix to circumvent the strict pragma (and if so, why?). Please be careful.

Also, if I understand the docs correcty, $cgi->https() does not necessarily return 'on' for a https connection but some value that's true.

Anyway I would probably use a subroutine and pass the object in explicitly, more or less like this: 

my $q = CGI->new;
check_https($q);

sub check_https {
  my ($cgi) = @_;
  unless ($cgi->https) {
     my $url = $cgi->url(-path_info=>1, -query =>1);
     s/^http:/https:/ or die "Unsupported URI scheme, or https detecti
+on error";
     print $cgi->redirect($url);
     exit;
  }
}

[download]
Ofcourse, this doesn't handle POST requests well.

edit: fixed typo.

"What should it profit a man, if he should win a flame war, yet lose his cool?"

In reply to Re: pass cgi object? by Joost
in thread pass cgi object? by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.