For integers, one can avoid reverse as well as the repeated substr derivation of the remaining string in the loop: 

sub commafy_int
{
    my $n = shift;
    length($n) > 3 or return $n;
    my $l = length($n) - 3;
    my $i = ($l - 1) % 3 + 1;
    my $x = substr($n,0,$i) . ',';
    while ( $i < $l )
    {
        $x .= substr($n,$i,3) . ',';
        $i += 3;
    }
    $x . substr($n,$i)
}

[download]
Not using reverse also makes it much easier to convert this to work on floats (i.e. strings containing a decimal separator, '.'). To do so, simply replace any length calls above with index($n.'.','.').

In reply to Re: How do I print a large integer with thousands separators? by Anonymous Monk
in thread How do I print a large integer with thousands separators? by miblo

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.