A hash lookup? Why not an array? Anyway, i wouldnt have laughed so hard if it had been written something like the following: 

Public Function GetMonthName(ByVal m As Long, _
    Optional ByVal abbr As Boolean = False) As String


    Static Months(12) As String
    If (Months(1) <> "January") Then
        Months(1) = "January"
        Months(2) = "February"
        Months(3) = "March"
        Months(4) = "April"
        Months(5) = "May"
        Months(6) = "June"
        Months(7) = "July"
        Months(8) = "August"
        Months(9) = "September"
        Months(10) = "October"
        Months(11) = "November"
        Months(12) = "December"
    End If
    
   Dim tmp As String

   If (m >= 1 And m <= 12) Then
        tmp = Months(m)
   Else
        tmp = Format(m, "0")
   End If

   If abbr Then
      GetMonthName = Left(tmp, 3)
   Else
      GetMonthName = tmp
   End If

End Function

[download]

---
demerphq

    First they ignore you, then they laugh at you, then they fight you, then you win.
    -- Gandhi

    Flux8


In reply to Re^4: The joys of bad code by demerphq
in thread The joys of bad code by BUU

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.