In your "patch" you used the following code 
if ( (unsigned)size > 1000000 ) Perl_croak(aTHX_ "Bugger!\n")

[download]
I noticed that the author had a CROAK macro and wondered why you opted for the Perl_croak and what the difference was. 
/** Storable.xs 1.0.13 **/
#define CROAK(x)        do { cxt->s_dirty = 1; croak x; } while (0)

[download]
/** Storable.xs 2.13 **/
#define CROAK(x)        STMT_START { cxt->s_dirty = 1; croak x; } STMT
+_END

[download]
I understand that the cxt->s_dirty is used to let Storable reuse the memory next time around, just wondering what the difference between croak and Perl_croak is.

-biz-

In reply to Re^2: Small Corrupted Storable Retrieve Dies With an Invalid "Out of memory!" by jbisbee
in thread Small Corrupted Storable Retrieve Dies With an Invalid "Out of memory!" by jbisbee

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.